-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implicitCount added to content search index #35000
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ee5b26f
to
a7757d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 @ChrisChV ! Good work.
- I tested this following the test instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
Can't you just compute this from the response? The |
Yes, it was one of my options, but I think that adding to the index would be the easiest way to obtain tag count without having to calculate it in all the responses that need the count tag. If you need the count tags it's easy to get it from the index. What do you think? |
I think it's so simple to calculate that we might as well just calculate it ourselves when we need it. But if we need to sort by the tag count or filter by the tag count, then we definitely need to add to the index. If we don't need that, I wouldn't bother personally. |
Make sense. Updated: open-craft/frontend-app-authoring@0843a1e |
This index change is not longe necessary for now. |
@ChrisChV Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Adds
implicit_count
to content search index.Supporting information
Testing instructions
./manage.py cms reindex_studio --experimental
.http://meilisearch.local.edly.io:7700/
and check if the created documents have thetags.implicit_count
field